Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!

Members: 0
Guests: 12
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
Evoru (32)
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] load_rooms doesn't prop...
Forum Rules | Mark all | Recent Posts

[Bug] load_rooms doesn't properly check sector types when loading rooms
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005, 3:58 pm   Last edited May 11, 2005, 6:40 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: The load_rooms function doesn't properly check sector types when loading a room.
Danger: High
Found by: Remcon
Fixed by: Remcon
-----
[db.c]

In load_rooms find:

        if (pRoomIndex->sector_type < 0 || pRoomIndex->sector_type == SECT_MAX)
        {
          bug( "Fread_rooms: vnum %d has bad sector_type %d.", vnum ,
              pRoomIndex->sector_type);
          pRoomIndex->sector_type = 1;
        }


Change it to:

        if (pRoomIndex->sector_type < 0 || pRoomIndex->sector_type >= SECT_MAX)
        {
          bug( "Fread_rooms: vnum %d has bad sector_type %d.", vnum ,
              pRoomIndex->sector_type);
          pRoomIndex->sector_type = 1;
        }


This can be bad because new areas may have sectors greater than SECT_MAX, and the code doesn't properly check for this.
       
Pages:<< prev 1 next >>