Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Exalead, Yahoo!, DotBot, Bing

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] MSet allows you to chan...
Forum Rules | Mark all | Recent Posts

[Bug] MSet allows you to change the name of a PC, and can set empty names
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005, 3:57 pm   Last edited May 11, 2005, 6:37 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: MSet allows you to change the name of a PC, and can set names to nothing.
Danger: MAXIMUM
Found by: Orion Elder
Fixed by: Orion Elder
-----
[build.c]
In do_mset find:

    if ( !str_cmp( arg2, "name" ) )
    {
        if ( !can_mmodify( ch, victim ) )
          return;
        if ( !IS_NPC(victim) && get_trust( ch ) < LEVEL_MASTER )
        {
            send_to_char( "Not on PC's.\n\r", ch );
            return;
        }


Change that to:

    if ( !str_cmp( arg2, "name" ) )
    {
        if ( !can_mmodify( ch, victim ) )
          return;
        if ( !IS_NPC( victim ) )
        {
            send_to_char( "Not on PC's.\n\r", ch );
            return;
        }


And below it add:

        if ( !arg3 || arg3[0] == '\0' )
        {
            send_to_char( "Names can not be set to an empty string.\n\r", ch );
            return;
        }


This has several potential problems. An empty name string makes for something that can not be targetted, first of al, and could case major problems. Being able to MSet a PCs name allows one to change their name to one that is already taken (thus resulting in confusion).

PCRename is made for that task anyway.
       
Pages:<< prev 1 next >>