Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Yandex, Google

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWR FUSS » Bug: show_File
Forum Rules | Mark all | Recent Posts

Bug: show_File
< Newer Topic :: Older Topic > Bug in db.c

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005, 7:22 pm
Go to the top of the page
Go to the bottom of the page

Greven
Magician
GroupMembers
Posts204
JoinedMar 5, 2005

The function show_file in db.c has a file descriptor leak. The function does not close the open descriptor. I have changed it to such and it works fine.

I checked in the swr1fuss.tgz file available on this site that the error is still present.
void show_file(CHAR_DATA * ch, char *filename){        FILE     *fp;        char      buf[MAX_STRING_LENGTH];        int       c;        int       num = 0;        if ((fp = fopen(filename, "r";)) != NULL)        {                while (!feof(fp))                {                        while ((buf[num] = fgetc(fp)) != EOF                               && buf[num] != ''                               && buf[num] != '
'                               && num < (MAX_STRING_LENGTH - 2))                                num++;                        c = fgetc(fp);                        if ((c != '' && c != '
') || c == buf[num])                                ungetc(c, fp);                        buf[num++] = '';                        buf[num++] = '
';                        buf[num] = '';                        send_to_pager(buf, ch);                        num = 0;                }                   fclose(fp);        }}


Of course, I use the FCLOSE macro, but thats something else entirely



       
Pages:<< prev 1 next >>