Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Yahoo!, Google

Members: 0
Guests: 6
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » AFKMud Support & Development » New Area Crash Bug in 2.0
Forum Rules | Mark all | Recent Posts

New Area Crash Bug in 2.0
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Dec 27, 2006, 10:50 am   Last edited Dec 27, 2006, 10:51 am by Zarius
Go to the top of the page
Go to the bottom of the page

Zarius
Apprentice
GroupMembers
Posts69
JoinedApr 23, 2002

Steps:
1. Vassign a new area to someone (i.e. Vassign Zarius 300 399)
2. Goto 300

Result:
Crash

It appears that roomdesc is null causing mudstrlcat to crash

mudstrlcat( rdesc, ch->in_room->roomdesc, MSL );


I'll debug in a bit unless someone figures it out before me, but I'm still trying to figure out where all the code went :)
       
Post is unread #2 Dec 27, 2006, 7:12 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Consider it debugged. Major oversight, but I'm glad it was caught now and not after launch!

Index: act_info.cpp
===================================================================
--- act_info.cpp        (revision 2)
+++ act_info.cpp        (working copy)
@@ -1101,7 +1101,7 @@
       {
          if( ch->in_room->nitedesc && ch->in_room->nitedesc[0] != '\0' )
             mudstrlcat( rdesc, ch->in_room->nitedesc, MSL );
-         else
+         else if( ch->in_room->roomdesc && ch->in_room->roomdesc[0] != '\0' )
             mudstrlcat( rdesc, ch->in_room->roomdesc, MSL );
       }
       if( ch->MXP_ON(  ) )
       
Post is unread #3 Dec 28, 2006, 10:53 am   Last edited Jan 13, 2007, 10:24 am by Samson
Go to the top of the page
Go to the bottom of the page

Lazerous

GroupMembers
Posts79
JoinedAug 10, 2005

Samson said:
Index: act_info.cpp
===================================================================
--- act_info.cpp        (revision 2)
+++ act_info.cpp        (working copy)
@@ -1101,7 +1101,7 @@
       {
          if( ch->in_room->nitedesc && ch->in_room->nitedesc[0] != '\0' )
             mudstrlcat( rdesc, ch->in_room->nitedesc, MSL );
-         else
+         else if( ch->in_room->roomdesc && ch->in_room->roomdesc[0] != '\0' )
             mudstrlcat( rdesc, ch->in_room->roomdesc, MSL );
       }
       if( ch->MXP_ON(  ) )


Ok I would now assume this is a section of "good" code now? This is the code to replace the bad section?
Appearing in this file: act_info.cpp ?
I just want to understand the format of your code releases for this sort of thing.
I got the same bug now I have to try to solve it with what I see above, its not much to go on for the noob
I seem to be more of then the exp admin I should be...
       
Post is unread #4 Dec 28, 2006, 12:11 pm
Go to the top of the page
Go to the bottom of the page

Zarius
Apprentice
GroupMembers
Posts69
JoinedApr 23, 2002

You can do a SVN Update to download the fixes
       
Post is unread #5 Dec 28, 2006, 12:12 pm   Last edited Dec 28, 2006, 12:13 pm by ryan_rae
Go to the top of the page
Go to the bottom of the page

Lazerous

GroupMembers
Posts79
JoinedAug 10, 2005

Sadly I can't find the syntax for that, I wrote it down and misplaced the paper...

Could I get the svn update syntax and the one to pull down the whole thing,
so if I need to do that, I can do that as well. Thank you.
       
Post is unread #6 Dec 28, 2006, 12:41 pm   Last edited Dec 28, 2006, 12:42 pm by kiasyn
Go to the top of the page
Go to the bottom of the page

kiasyn
Magician
GroupMembers
Posts121
JoinedJun 30, 2006

the synax is 'svn update'

svn help is extremely useful.
       
Post is unread #7 Dec 28, 2006, 2:32 pm
Go to the top of the page
Go to the bottom of the page

Lazerous

GroupMembers
Posts79
JoinedAug 10, 2005

Thank you I will try that, but its not in the original folders anymore, so I doubt thats going to be effective.
However the svn help would be as man svn wasn't.
       
Post is unread #8 Dec 28, 2006, 4:00 pm   Last edited Dec 28, 2006, 4:01 pm by Conner
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

Even just 'svn up' will work, though if you've moved the folder elsewhere, it may be that you need to try that command from that folder, which may cause even more problems since you'll at some point want to make your own changes, what'll work better, most likely, would be to redo your 'cvs co' and then make a diff of that src folder and your own and then make the changes from that.

Next point, Samson posted:
Index: act_info.cpp
===================================================================
--- act_info.cpp        (revision 2)
+++ act_info.cpp        (working copy)
@@ -1101,7 +1101,7 @@
       {
          if( ch->in_room->nitedesc && ch->in_room->nitedesc[0] != '\0' )
             mudstrlcat( rdesc, ch->in_room->nitedesc, MSL );
-         else
+         else if( ch->in_room->roomdesc && ch->in_room->roomdesc[0] != '\0' )
             mudstrlcat( rdesc, ch->in_room->roomdesc, MSL );
       }
       if( ch->MXP_ON(  ) )
as the solution, that's a diff file showing that, within the file act_info.cpp, you need to find the section of code that outlines (roughly around line 1101 of that file) and replace the
else
with
else if( ch->in_room->roomdesc && ch->in_room->roomdesc[0] != '\0' )


Not that you should just paste that whole block in.
       
Post is unread #9 Dec 28, 2006, 6:26 pm
Go to the top of the page
Go to the bottom of the page

Zarius
Apprentice
GroupMembers
Posts69
JoinedApr 23, 2002

ryan_rae said:

Sadly I can't find the syntax for that, I wrote it down and misplaced the paper...

Could I get the svn update syntax and the one to pull down the whole thing,
so if I need to do that, I can do that as well. Thank you.


Ahh, I was using the windows SVN client (TortoiseSVN), so it may be different.
       
Post is unread #10 Dec 28, 2006, 6:42 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

http://svnbook.red-bean.com/en/1.1/ch09.html

The SVN resource I use when I have problems or questions about SVN commands and such. I link to chapter 9, but the whole thing is probably worth a read for those who aren't familiar with it.

And yes, in Windows the TortoiseSVN client is probably as good as it gets. I use it myself.
       
Post is unread #11 Dec 28, 2006, 6:56 pm
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

I agree with Samson, I also use TortoiseCVS/TortoiseSVN because it seems to be the best I've found for the Windows side of CVS/SVN for me too. As for the syntax of svn update in Windows under TortoiseSVN, you just right click on the folder where you checked out the SVN respository and select SVN Update.
       
Post is unread #12 Jan 3, 2007, 10:29 pm
Go to the top of the page
Go to the bottom of the page

Lazerous

GroupMembers
Posts79
JoinedAug 10, 2005

Well it appears that this bug may not be totally gone, when I vassign self 1100 1600 then goto 1100, then
redit name &cProtection Way &y[&RTuroth City&Y]&w the mud crashes, and my char is booted each time I log in after that. I had to restore an old copy, edit the gods file delete the build file etc...
       
Post is unread #13 Jan 3, 2007, 11:22 pm
Go to the top of the page
Go to the bottom of the page

Lazerous

GroupMembers
Posts79
JoinedAug 10, 2005

Ok this also occurs when I goto a room not yet created in an area with the vnums assigned to it.
Such as: say an area has the vnums 1100 to 1600 and only say 25 are used, so I goto the 26th one to make
a new room and poof it dies. So this is not just on newly vassigned areas, I mean areas not yet installed, this
is happening as well to installed areas.
       
Post is unread #14 Jan 4, 2007, 6:19 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

I'll need to look into the room name changing problem. That's very likely a separate issue from the original bug report.

As for the second one. It makes no difference if the area is freshly created or has been sitting around for awhile. Crashes for unset information are usually caused by something being missing. That being said, when I vassigned myself a new range to duplicate Zarius' original post, the only crash came from the missing room description. I hadn't set any of the other data yet so I'm not sure why it didn't complain. It's likely I'm going to need to get a core dump in order to pin this one down since it's not one I can replicate.
       
Post is unread #15 Jan 4, 2007, 9:32 am
Go to the top of the page
Go to the bottom of the page

Lazerous

GroupMembers
Posts79
JoinedAug 10, 2005

Ok maybe I will take a break from finding bugs after this one and just concentrate on building my city...
       
Post is unread #16 Jan 5, 2007, 7:51 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Definitely going to need a core dump on crashing with no area name. The code autosets "Engulfed in a Swirling Mass of Void Space" as a name on all new rooms created. Actually.... I'll just quote a default room:

With map:
Engulfed in a Swirling Mass of Void Space                  -     -     -
-<---- Vnum:   9001 ----------------------------->-        -<---(*)--->-
                                                           -     -     -
[Area Flags: prototype]
[Room Flags: proto]
[Sector Type: indoors] [Continent or Plane: alsherok]
[Area name: [PROTO] Samson's area in progress]  [Area filename: Samson.are]
[Exits: none]
+-----------+ (Not set)
|           | 
|           | 
|           | 
|           | 
|     @     | 
|           | 
|           | 
|           | 
|           | 
+-----------+ 


Without map:
Engulfed in a Swirling Mass of Void Space                  -     -     -
-<---- Vnum:   9001 ----------------------------->-        -<---(*)--->-
                                                           -     -     -
[Exits: none]
[Area Flags: prototype]
[Room Flags: proto]
[Sector Type: indoors] [Continent or Plane: alsherok]
[Area name: [PROTO] Samson's area in progress]  [Area filename: Samson.are]
(Not set)
       
Pages:<< prev 1 next >>