Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, DotBot, Yahoo!

Members: 0
Guests: 5
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » AFKMud Support & Development » Bad exit flag!
Forum Rules | Mark all | Recent Posts

Bad exit flag!
< Newer Topic :: Older Topic >

Pages:<< prev 1, 2 next >>
Post is unread #1 Nov 21, 2006, 5:48 am
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

I am hoping someone can help.

redit bexit s vnum 3 gate......always returns Bad exit flag!

I tried a few other exit-types number to no avail.

Thanks, in advance
       
Post is unread #2 Nov 21, 2006, 6:55 am
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

Maybe I should add.

Using AFKmud 1.77, just downloaded it the other day.
I can add flags with redit exflag dir <flags> and it sets the flag

1) n to 10018 Key: -1 Keywords: (none) Flags: isdoor closed.

But when you try to open/close the door it say. You see no door here.
Even when I set it on both sides of the door.

thanks again
       
Post is unread #3 Nov 21, 2006, 10:22 am
Go to the top of the page
Go to the bottom of the page

Moridian

GroupMembers
Posts5
JoinedNov 13, 2006

pstone said:

Maybe I should add.

Using AFKmud 1.77, just downloaded it the other day.
I can add flags with redit exflag dir <flags> and it sets the flag

1) n to 10018 Key: -1 Keywords: (none) Flags: isdoor closed.

But when you try to open/close the door it say. You see no door here.
Even when I set it on both sides of the door.

thanks again

Have you done 'open north' ??

It wouldn't respond to 'open door' unless you add a keyword 'door' to the exit.

-Moridian
       
Post is unread #4 Nov 21, 2006, 5:34 pm
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

pstone said:

I am hoping someone can help.

redit bexit s vnum 3 gate......always returns Bad exit flag!

I tried a few other exit-types number to no avail.

Thanks, in advance


have you tried it without the word vnum in there?
       
Post is unread #5 Nov 21, 2006, 6:10 pm
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

I just put vnum instead of an actual number....

redit bexit s 1000 3 gate

Bad exit flag!
New exit added.
       
Post is unread #6 Nov 21, 2006, 7:19 pm   Last edited Nov 21, 2006, 7:20 pm by Conner
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

Ok, that's just weird then, so it's creating the exit, but not liking the flag for it.. hmm, 3, wouldn't that be isdoor + closed?

Would it take it as:
redit bexit s 1000 isdoor closed gate

Or, is it saying it's a bad flag because it's reading the "gate" as part of the flags addition attempt?
       
Post is unread #7 Nov 21, 2006, 7:54 pm
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

redit bexit s 1000 isdoor closed gate

that gives me an exit south that has a door with keywords closed gate
       
Post is unread #8 Nov 21, 2006, 8:06 pm
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

I should say that it does not seem to be reading the bitvector info...

Even if I put...redit bexit s 1000 3
just gives me an open exit south

Just so much easier to use the bitvectors then redit exflags isdoor closed etc...since I have to do all but isdoor on both sides currently...

Wonder if I am doing something wrong, of if something is screwy.

Thanks, btw.
       
Post is unread #9 Nov 21, 2006, 8:15 pm
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

Hmm, but it didn't give you "Bad exit flag!" this time... if we come up with a fix for this for you, can we also make it tell you "Good exit flag!" each time you add an exit that has a valid flag on it? :devil:
       
Post is unread #10 Nov 21, 2006, 8:22 pm
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

Ah...the power!
       
Post is unread #11 Nov 21, 2006, 8:41 pm   Last edited Nov 21, 2006, 8:42 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Wonder if I am doing something wrong, of if something is screwy.


Something *IS* screwy, and I'm surprised it's taken 9+ years to be uncovered and noticed.

This is the syntax message for "redit exit":
Usage: redit exit <dir> [room] [flags] [key] [keywords]


One might quickly notice the problem here if one is sharp. Notice where [flags] is sitting. The flags field is meant to accept multiple arguments. But the code for this part of redit is only configured to accept single arguments. The breakdown should become obvious at this point :)

But yeah. This needs a fix, and I'll throw something together for it. Probably won't be tonite. Most likely sometime later tomorrow nite. It's going to mean removing flags ( and keywords ) from this part of the code and emphasizing the existing proper commands which are already in place.

Good eye though, finding genuine 9 year old fubars like this doesn't happen that often :)
       
Post is unread #12 Nov 21, 2006, 8:42 pm
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

Sorry, Pstone, really not picking on you, just really couldn't resist a wise crack about the message itself.. it reminded me of the old BBS days when we had taglines on all our emails and there was one floating around that said "Ever notice that DOS never says "Good Command!"?"... there was another that said "Bad command! Go to the corner!" ...and many others too.. anyway, wasn't knocking you, this is a good catch, now we just need to figure out how to fix it for you.. and the rest of us too.
       
Post is unread #13 Nov 21, 2006, 11:16 pm
Go to the top of the page
Go to the bottom of the page

kiasyn
Magician
GroupMembers
Posts121
JoinedJun 30, 2006

before:
Usage: redit exit <dir> [room] [flags] [key] [keywords]
after:
Usage: redit exit <dir> [room] '[flags]' [key] [keywords]

all fixed.
       
Post is unread #14 Nov 22, 2006, 4:28 am
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

Well, glad it is not me being a total idiot.
I appreciate the help/work looking into it.

And I did not take it as a knock Conner....I have a sense of humor too. :biggrin:
       
Post is unread #15 Nov 22, 2006, 6:27 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

kiasyn said:

before:
Usage: redit exit <dir> [room] [flags] [key] [keywords]
after:
Usage: redit exit <dir> [room] '[flags]' [key] [keywords]

all fixed.


Fails to actually solve the problem. Having to remember to put quotes around a multi-argument argument ( say that 10 times fast! ) is too prone to error. I'd much rather eliminate this as a potential block. The redit command has an "exflags" argument for a reason, may as well encourage its use. Especially since the helpfiles on this subject don't match the actual command syntax :)
       
Post is unread #16 Nov 22, 2006, 12:21 pm
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

PStone: Glad to hear it, Samson pointed out to me that it could be taken that way and I didn't want you to misunderstand.

Samson: So you're saying that, while simply adding single quotes around your exit flags will work, since we'd have to at least fix the syntax message in its corresponding help file, we might as well fix the function itself so that it no longer accepts flag strings or a bit vectors but instead forces you to use exflags for adding flags and exname for adding keywords? While we're at it, why not make it so that redit exit and redit bexit also no long support adding key assignments at this point so folks have to use exkey as well? :sad:
Isn't there a better alternative to somehow make the exit and bexit options work the way they're supposed to rather than stripping them of the parts that do work? Maybe we could just change the order it takes arguments (keyword then flags instead of flag then keyword) and make it accept a string names for the flags or a bit vector for them and then fix the help file instead?
       
Post is unread #17 Nov 22, 2006, 12:40 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

You can't have 2 multiple argument segments of a command without causing problems. The quote thing is a bit of a hack really, and terribly inconvenient if you are like most and forget it's necessary. The key assignment is a single argument so it won't hurt anything staying there.
       
Post is unread #18 Nov 22, 2006, 12:51 pm
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

But there really should be some way to do it.. maybe if we made it only accept a bit vector for flags? At least then it'd still work correctly, and only be needing to accept one value for that argument. And for those who needed/wanted to spell out the flag names, they could use exflags.
       
Post is unread #19 Nov 22, 2006, 1:30 pm
Go to the top of the page
Go to the bottom of the page

pstone

GroupMembers
Posts32
JoinedNov 26, 2006

I would be all in favor of the bitvector method...
I seem to use exit and bexit to quickly create...and thus adding or changed flags with redit exflags later is fine.

What I don't like about redit exflags, unless I am missing something, is you have to set them twice...from both sides of the door.

       
Post is unread #20 Nov 22, 2006, 4:46 pm
Go to the top of the page
Go to the bottom of the page

Conner
Sorcerer
GroupMembers
Posts870
JoinedMay 8, 2005

Hmm, I wonder how hard it'd be to make a bexflags to accompany exflags...
       
Pages:<< prev 1, 2 next >>