Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
Bug in do_drag( )
Oct 8, 2017, 12:40 am
By GatewaySysop
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Beastmaster 6D sound files
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot, Yahoo!

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
476
3,704
19,231
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Global weath_unit value...
Forum Rules | Mark all | Recent Posts

[Bug] Global weath_unit value is not properly validated
< Newer Topic :: Older Topic > AFKMud 1.77

Pages:<< prev 1 next >>
Post is unread #1 Oct 29, 2006, 2:05 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Global weath_unit value is not properly validated.
Danger: Critical - Crashes if set to zero. Numerous unchecked divisional uses.
Discovered in: AFKMud 1.77
Found by: Remcon
Fixed by: Remcon

---

db.c, do_setweather

Locate:
   else if( !str_cmp( arg, "unit" ) )
   {
      if( !is_number( argument ) )
      {
         ch_printf( ch, "Set weather unit " "size to what?\r\n" );
      }
      else
      {
         weath_unit = atoi( argument );
         ch_printf( ch, "Weather unit size " "now equals %d.\r\n", weath_unit );
         save_weatherdata(  );
      }
   }


Change to:
   else if( !str_cmp( arg, "unit" ) )
   {
      if( !is_number( argument ) )
         ch_printf( ch, "Set weather unit size to what?\r\n" );
      else
      {
         int unit = atoi( argument );

         if( unit == 0 )
         {
            send_to_char( "Weather unit size cannot be zero.\r\n", ch );
            return;
         }
         weath_unit = unit;
         ch_printf( ch, "Weather unit size now equals %d.\r\n", weath_unit );
         save_weatherdata(  );
      }
   }


db.c, load_weatherdata

Locate:
         else if( !str_cmp( word, "UNIT" ) )
            weath_unit = fread_number( fp );


Change to:
         else if( !str_cmp( word, "UNIT" ) )
         {
            int unit = fread_number( fp );

            if( unit == 0 )
               unit = 1;

            weath_unit = unit;
         }


While this fix may not look espeicially bad, it will become crystal clear after setting this value to 0. There are numerous places in the weather related code that use weath_unit as a divisor. Dividing by zero is a Bad Thing(tm) and will bring your came crashing down rather abruptly. Since this value is also saved upon being set, it may make it difficult to get the mud back up when one does not realize why there's a problem.
       
Pages:<< prev 1 next >>