Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing, Yandex

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] pcrename incorrectly ch...
Forum Rules | Mark all | Recent Posts

[Bug] pcrename incorrectly checks the user's area instead of the target's
< Newer Topic :: Older Topic > AFKMud 1.63

Pages:<< prev 1 next >>
Post is unread #1 Apr 24, 2004, 11:52 am   Last edited Nov 13, 2005, 12:16 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: pcrename command incorrectly checks the user's area instead of the target's
Discovered in: AFKMud 1.63
Danger: Medium - Data corruption
Found by: Zebeid
Fixed by: Zebeid

pfiles.c, do_pcrename

Locate the following:

    /* Remember to change the names of the areas */
   if( ch->pcdata->area )  
   {   
      char filename[256], newfilename[256];
     
      snprintf( filename, 256, "%s%s.are", BUILD_DIR, victim->name ); 
      snprintf( newfilename, 256, "%s%s.are", BUILD_DIR, capitalize( argument ) );
      rename( filename, newfilename );
      snprintf( filename, 256, "%s%s.are.bak", BUILD_DIR, victim->name );
      snprintf( newfilename, 256, "%s%s.are.bak", BUILD_DIR, capitalize( argument ) );
      rename( filename, newfilename );
   }


Change to:

    /* Remember to change the names of the areas */
   if( victim->pcdata->area )  
   {   
      char filename[256], newfilename[256];
     
      snprintf( filename, 256, "%s%s.are", BUILD_DIR, victim->name ); 
      snprintf( newfilename, 256, "%s%s.are", BUILD_DIR, capitalize( argument ) );
      rename( filename, newfilename );
      snprintf( filename, 256, "%s%s.are.bak", BUILD_DIR, victim->name );
      snprintf( newfilename, 256, "%s%s.are.bak", BUILD_DIR, capitalize( argument ) );
      rename( filename, newfilename );
   }


A subtle yet very important little problem. Having one's own area renamed unintentionally would generally not be good. Or worse, having this command crash because the person who used the command had no area pointer!
       
Pages:<< prev 1 next >>