Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, DotBot, Yahoo!

Members: 0
Guests: 5
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Deity worshipper count ...
Forum Rules | Mark all | Recent Posts

[Bug] Deity worshipper count is not safeguarded against going negative
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Feb 28, 2005, 5:35 pm   Last edited Nov 13, 2005, 11:54 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Deity worshipper count is not safeguarded against going negative in do_devote
Discovered in: AFKMud 1.64
Danger: Trivial ( if pfile clean is on ) / Low ( if pfile cleanup is off ) - Incorrect counter value
Found by: Celestria
Fixed by: Celestria

---

deity.c, do_devote

Locate:

      if( !ch->pcdata->deity )
        {
           send_to_char( "You have already chosen to worship no deities.\n\r", ch );
           return;
        }
        --ch->pcdata->deity->worshippers;


Change to:

      if( !ch->pcdata->deity )
        {
           send_to_char( "You have already chosen to worship no deities.\n\r", ch );
           return;
        }
        --ch->pcdata->deity->worshippers;
      if( ch->pcdata->deity->worshippers < 0 )
         ch->pcdata->deity->worshippers = 0;


Players who choose to "devote none" were not adjusting the worshipper count. As far as I'm aware, this doesn't cause any significant harm in the long run, but accuracy of information is still important. The affect of this bug is mitigated to nothing if you have the pfile autocleanup code enabled in cset, the counts will be adjusted automatically at the next update cycle. If not, then the counts will never be updated, they will just be wrong until someone either enables the cleanup, or fixes the files manually.
       
Pages:<< prev 1 next >>