Bug: String hash code reports incorrect amount of memory saved.
Discovered in: AFKMud 1.64
Danger: Trivial - Miscalculated display value.
Found by: Remcon
Fixed by: Remcon
hashstr.c, function hash_stats
Locate this line:
wouldhave += ( ptr->links * ( ptr->length + 1 ) );
Change it to this:
wouldhave += ( sizeof(struct hashstr_data) + (ptr->links * (ptr->length + 1)) );
The miscalculation will only truly be noticable on small muds with only a few hashed strings. It may well have gone completely unnoticed had Remcon not used the hashing code in another project and discovered that it was reporting negative data.
This bug also affects other Smaug derived codebases.