SmaugMuds.org - Topic: Affects - Overhauling the system

Affects - Overhauling the system

nobody@example.com (Remcon) — Thu, 26 Nov 2009 18:34:50 PST

Actually I ran across this one long ago when I was redoing some affect stuff (don't recall right off what or when), but I never posted it since I figured it was just some changes I had made lol. I do recall that I ended up doing away with what the old affected did and instead went with what it used for xaffected for the affected.

Affects - Overhauling the system

nobody@example.com (Kayle) — Thu, 26 Nov 2009 11:44:06 PST

Funny Story.

Somewhere along the lines, updating affects to use XBVs broke the sset system.

You can't use sset affect affected anymore.

If you do, you end up with some funky ass results. Instead, you have to use sset affect xaffected to get proper results. An example.

[quote]Log: Kayle: sset acute_awareness affect affected detect_hidden l*10 detect_hidden

Sn: 5 Slot: 0 Skill: 'acute_awarene

Affects - Overhauling the system

nobody@example.com (David Haley) — Tue, 23 Jun 2009 19:44:46 PDT

I think this is kind of an interesting crossroads for the FUSS project, actually. For a while, it was just fixing bugs. Then a lot of the bugs were fixed, and people started to want improvements, or "feature fixes" -- not actually fixing [i]bugs[/i], but fixing things that didn't behave quite right, or at least not in a terribly sane manner. And so the reset, weather, etc. changes came to be.

But eventually, as you start fixing "features" of the codebase, you run into things that are [i]truly

Affects - Overhauling the system

nobody@example.com (Metsuro) — Tue, 23 Jun 2009 19:17:32 PDT

[quote=Conner]Metsuro, I refer you to:
[quote=David Haley]Sometimes I feel like when you start fixing these fundamental design issues, it's almost like writing a new game. Except if you did that you wouldn't have the stupid license requirement anymore...[/quote]
along with:
[quote=Kayle]Like David said, if we're going to rework something this fundamental, we might as well be writing a new codebase.[/quote]
So, yes, we are talking about actually starting over frm scratch if it came to that.

Affects - Overhauling the system

nobody@example.com (Conner) — Tue, 23 Jun 2009 19:04:28 PDT

Metsuro, I refer you to:
[quote=David Haley]Sometimes I feel like when you start fixing these fundamental design issues, it's almost like writing a new game. Except if you did that you wouldn't have the stupid license requirement anymore...[/quote]
along with:
[quote=Kayle]Like David said, if we're going to rework something this fundamental, we might as well be writing a new codebase.[/quote]
So, yes, we are talking about actually starting over frm scratch if it came to that. Alternatively,

Affects - Overhauling the system

nobody@example.com (Samson) — Tue, 23 Jun 2009 18:25:00 PDT

Conner, I think it's pretty obvious at some point that we went beyond "just fixing" and have been making improvements along the way. The reset system back in 1.6 was an example of that. Still justifiably a fix, but at the same time it did significantly rework an existing system into something it was not. The same happened with the weather code. However none of these has actually caused significant breakage of the codebase. Even the trap reform wouldn't be a significant breakage, mainly because t

Affects - Overhauling the system

nobody@example.com (Metsuro) — Tue, 23 Jun 2009 18:21:43 PDT

But creating a new base, are we referring from complete scratch, or just relabeling this after the large changes. Wouldn't still be a derv since it started out as smaug, even though its changed a bit from the original wouldn't it still have to follow the license agreements? You cant really just remove parts and redo them and call it an original work can you?

Affects - Overhauling the system

nobody@example.com (Conner) — Tue, 23 Jun 2009 17:59:06 PDT

Metsuro, I think Quixadhal's on the right track here with this. If we make the changes as proposed, at this point it'd probably be better to just start with a clean slate altogether and end up with something that's Smaug-like without the license issues nor the hassle of trying to make all the old parts fit with the new engine, to continue your analogy. If we're honestly just trying to Fix Up the old Smaug Source, this may be beyond our scope and it's certainly not going to be something most admi

Affects - Overhauling the system

nobody@example.com (Metsuro) — Tue, 23 Jun 2009 17:26:03 PDT

Well as I see it, we can not do this and complain about the system and just try to keep patching the old worn tire. Or we can spend the money(time) and buy the new one, and then redo some of the old snippets to work in the new system. Do we want to make the base fun and enjoyable or just something we can deal with and suffer as we just fester in a pool of poor design. Alot of the old snippets and such dont work without changing them in some way, should we let this limit the growth of the base? I

Affects - Overhauling the system

nobody@example.com (Quixadhal) — Tue, 23 Jun 2009 15:33:43 PDT

Agreed. It would be a significant enough change to perhaps need to come up with a new name for the codebase. That's NOT saying it shouldn't be done, just that one needs to decide what it IS that makes something "Smaug".

My own little foray into reworking ROM into RaM showed that there seem to be two clumps of people interested in the project. One group wants everything to remain 99% the same, to the point that snippets could still be applied. The other wants to rework everything so it mak