SmaugMuds.org - Forum: SWR FUSS

Help with garbage variables

nobody@example.com (Remcon) — Mon, 9 Aug 2010 17:42:18 PDT

It really isn't to bad and I long ago decided to just put everything in it instead of using both shared and non shared strings to make it easier to keep track of.

Help with garbage variables

nobody@example.com (David Haley) — Sun, 8 Aug 2010 21:10:38 PDT

Shared strings introduce a (very small) amount of overhead during creation and freeing, and take up a (very small) amount of extra memory. Additionally, shared strings are, well, shared, so you can't just modify it as you please: you need to create a temporary copy, modify it, and then put it back into the shared string system.

So you would not use a shared string if:
- you were very concerned about every last byte of memory and processor instruction (the chances of this being true are next

Help with garbage variables

Shoie13@gmail.com (Banner) — Sun, 8 Aug 2010 06:00:20 PDT

[quote=David Haley][quote]What's the difference between str_dup/dispose and the STRFREE/ALLOC anyway? [/quote]

STRFREE and STRALLOC use a shared string mechanism (using reference counting) whereas str_dup and dispose don't. So, dispose will delete memory immediately even if other strings are using it; strfree on a non-shared pointer will look for reference count data that doesn't exist.[/quote]What's an example of a situation where str_dup would be favored over STRALLOC?

Help with garbage variables

nobody@example.com (David Haley) — Sat, 7 Aug 2010 23:00:32 PDT

[quote]What's the difference between str_dup/dispose and the STRFREE/ALLOC anyway? [/quote]
STRFREE and STRALLOC use a shared string mechanism (using reference counting) whereas str_dup and dispose don't. So, dispose will delete memory immediately even if other strings are using it; strfree on a non-shared pointer will look for reference count data that doesn't exist.

Help with garbage variables

Shoie13@gmail.com (Banner) — Sat, 7 Aug 2010 11:32:45 PDT

[quote=Kayle]You need to double check that the clan names aren't being assigned using str_dup anywhere. They all need to use the same. if you want to use STRALLOC/STRFREE on the clan_name fields, then ALL changes to clan_name need to use STRALLOC/STRFREE, not just the accounts part of things.[/quote]
Everywhere I access the player->clan variable I use STRFREE/ALLOC. Does that mean this is bad (can I not smash an str_dupped variable into a STRALLOC'd variable)?

[code]
ch->pcdata->clan->name

Help with garbage variables

nobody@example.com (Remcon) — Sat, 7 Aug 2010 09:38:32 PDT

[quote]
[code]
if( ch->pcdata->clan )
{
if( player->clan )
STRFREE( player->clan );
player->clan = STRALLOC( ch->pcdata->clan->name );
}
else
{
if( player->clan )
STRFREE( player->clan ); // LINE 178
player->clan = STRALLOC( "" );
}
[/code]
[/quote]
Instead of doing it like that I would do it like this
[code]
player->clan = N

Help with garbage variables

nobody@example.com (Kayle) — Sat, 7 Aug 2010 07:34:13 PDT

You need to double check that the clan names aren't being assigned using str_dup anywhere. They all need to use the same. if you want to use STRALLOC/STRFREE on the clan_name fields, then ALL changes to clan_name need to use STRALLOC/STRFREE, not just the accounts part of things.

Help with garbage variables

Shoie13@gmail.com (Banner) — Fri, 6 Aug 2010 17:32:37 PDT

I'm saving player data to my accounts and getting garbage saved under the clan variable.

[code]
#PLAYER
Name Matthis~
Level 100
Clan Àå@ h98 ^Ðñå·^Ðñå·^Øñå·^Øñå· ñå· ñå·¨ñå·¨ñå·°ñå·°ñå·¸ñå·¸ñå·Àñå·Àñå·(w% ¨^Ò@ ^HH8 ^ØR8 Øñå·Øñå·àñå·àñå· V9 V9 ðñå·ðñå·øñå·øñå·~
Created 1280033744
LogOff 1280497022
LogOn 1280491969
Logons 3
Room 300
End
[/code]

I do g

move_char bug with positions

nobody@example.com (Conner) — Wed, 4 Aug 2010 21:39:02 PDT

Sounds good. :)

move_char bug with positions

nobody@example.com (Kayle) — Tue, 3 Aug 2010 17:38:33 PDT

Yeah, I'll get it posted and released hopefully tomorrow after work.